Skip to content

Remove deprecated crx.writeFile() #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 3, 2019
Merged

Remove deprecated crx.writeFile() #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions src/crx.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
"use strict";

var fs = require("fs");
var path = require("path");
var join = path.join;
var crypto = require("crypto");
Expand Down Expand Up @@ -84,28 +83,6 @@ class ChromeExtension {
});
}

/**
* Writes data into the extension workable directory.
*
* @deprecated
* @param {string} path
* @param {*} data
* @returns {Promise}
*/
writeFile (path, data) {
var absPath = join(this.path, path);

/* istanbul ignore next */
return new Promise(function(resolve, reject) {
fs.writeFile(absPath, data, function(err) {
if (err) {
return reject(err);
}

resolve();
});
});
}

/**
* Generates a public key.
Expand Down
4 changes: 1 addition & 3 deletions test/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,7 @@ test('#writeFile', function(t){

var crx = newCrx();

crx.writeFile('/tmp/crx', new Error('')).catch(function(err){
t.ok(err);
});
t.throws(() => crx.writeFile('/tmp/crx'));
});

test('#loadContents', function(t){
Expand Down