Feat(button): use ButtonColor (highlight and danger) #257
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/makeinvietnam/moai-docs/BfHnPWyngCwkBRKbtoJeDmfWeU6J |
monodyle
reviewed
Jul 9, 2021
core/src/button/button.tsx
Outdated
| const getColor = (props: ButtonProps) => { | ||
| if (props.highlight !== undefined && props.color !== undefined) | ||
| throw Error( | ||
| "highlight and color cannot be defined at the same time. Use color only" |
There was a problem hiding this comment.
Should be put attribute name in the backtick? I think it will be easier to scan.
| }); | ||
|
|
||
| export const Danger = (): JSX.Element => ( | ||
| <Button color={Button.color.danger} children="Danger" /> |
There was a problem hiding this comment.
Can we have an outline style? And some description if it could be.
Let button style chooses the color
thien-do
approved these changes
Jul 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.