Skip to content

refactor: standardisation escalation contracts #461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 20 commits into
base: master
Choose a base branch
from
Open

refactor: standardisation escalation contracts #461

wants to merge 20 commits into from

Conversation

@suanjiansalt
Copy link
Contributor

@suanjiansalt suanjiansalt commented May 15, 2024 •
edited
Loading

Scope

Oct 1, 2025 Update:

  • Re-write all strings. All objective strings are UI_PEACOCK_{ESCALATIONCODE}_OBJ_{ACTION}_NAME/_DESC/_HUD. This took a while.
  • Added VR bricks for all Peacock escalations. It has been implemented in e9da11d.
  • Complete Metadata section, like CodeName_Hint and Release. As suggested, they have been removed.
    • Fix almost escalations' objective display order to make them appear more smoothly.
    • Force display order for all Peacock exclusive escalations (especially for "level 1"s).
  • Change yulania codename to asteria. (Imagepack changes required. )
  • Fix image paths for cmchaos and piratesproblem to avoid unnecessary images/objectives folders.

Image pack fix will be soon when this one gets checked.

Test Plan

Checklist

  • I have run Prettier to reformat any changed files
  • I have verified my changes work

@suanjiansalt suanjiansalt self-assigned this May 15, 2024
@suanjiansalt suanjiansalt added the escalations Related to the escalation system or a specific escalation. label Aug 9, 2024
@suanjiansalt suanjiansalt mentioned this pull request Aug 23, 2024
Merged
@RDIL RDIL reopened this Aug 23, 2024
@RDIL RDIL self-requested a review August 23, 2024 16:03
@suanjiansalt suanjiansalt changed the title style: standardisation escalation contracts refactor: standardisation escalation contracts May 4, 2025
@RDIL
Copy link
Member

RDIL commented Sep 24, 2025

Looks like there are a lot of conflicts here.

Complete Metadata section, like CodeName_Hint and Release.

We strip these out intentionally as they are only used by IOI's internal tools

@suanjiansalt
Copy link
Contributor Author

suanjiansalt commented Oct 1, 2025

Conflicts resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AnthonyFuller AnthonyFuller Awaiting requested review from AnthonyFuller AnthonyFuller is a code owner

@RDIL RDIL Awaiting requested review from RDIL

Assignees

@suanjiansalt suanjiansalt

Labels

escalations Related to the escalation system or a specific escalation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@suanjiansalt @RDIL @AnthonyFuller