Ensure callback is called only once #144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43081j
reviewed
May 23, 2025
| ) | ||
| return; | ||
|
|
||
| this.pushDirectory(directoryPath, paths, filters); |
Contributor
There was a problem hiding this comment.
does this change mean the root directory isn't pushed anymore? presumably directoryPath can be /, so this change would mean we push the child directories but not / itself.
that may be right, just checking i understand the logic and if this is a change in behaviour
Contributor
|
looks good to me! it may be worth adding a test for pretty sure we already test maxDepth elsewhere, just not at the root |
Contributor
Contributor
Contributor
This was referenced Jun 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #143
This PR fixes multiple issues with the
queue/enqueuelogic ensuring:onQueueEmptyis called only onceAnother change I had to make was how the crawler always returned results
maxDepth + 1deep. This might break some things (but not really sure since all tests pass).cc @SuperchupuDev can you test this out with
tinyglobbyand let me know if something breaks?