Improves debugging for events config + fixes inconsistencies in events.json #93595
+12
−60
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About The Pull Request
If an event is not found in the list, it will be null, so the stack trace when there is an invalid one in there will always return "Invalid event attempting to be configured." AKA nothing useful to indicate which event in the config is actually causing the failure.
Also stops stack trace from declaring 'invalid' config when they are simply not loaded due to the current map.
It should be printing out [variable] instead.
Also removes a bunch of non existent events from the events.json and fixes a few inconsistencies with the default weights.
Why It's Good For The Game
Stack traces with useful information are good.
Changelog
Nothing player-facing