Allow set_target to set ground truth in Performance&Fairness panel #2314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jameswex please review. |
jameswex
approved these changes
Jun 5, 2019
wchargin
approved these changes
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
set_target now sets the ground truth feature in WIT as well. Before, user had to select ground truth feature in Fairness&Performance panel even after setting it in WitConfig.
Technical description of changes
Modified js code to update the selectedLabelFeature variable based on config.
Screenshots of UI changes
Detailed steps to verify changes work correctly (as executed by you)
I ran a cloud AI platform model for census data both on local jupyter notebook and public colab notebook.
Alternate designs / implementations considered