Redo add umap-js to embedding projector #2112
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wchargin
reviewed
Apr 16, 2019
There was a problem hiding this comment.
This reverts #2091. Could you please add the text,
This reverts commit 58df24b5aad3c828e8d87c3e8abbc507f8bc68b7.
somewhere in the commit message/PR description? (This is the same text
that would have been included by git revert.)
This reverts commit 58df24b.
wchargin
reviewed
Apr 17, 2019
There was a problem hiding this comment.
I can’t build this internally. See http://cl/244071934.
Resolved; this is fine.
wchargin
approved these changes
Apr 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I've got everything working with the reimport back into google3 - there are a few CLs for wchargin@ to review and then we should be good to go. Let's follow up on this next Monday.
This reverts commit 58df24b.