Revert "Add UMAP to embedding projector (#1901)" #2091
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This reverts commit 37c5b50. Manual merge of `third_party/js.bzl` was required due to #2079; the file is now identical to its state prior to #1901. This is a temporary measure to keep our GitHub-to-Google sync process green while we work on integrating the `umap-js` library into google3. Test Plan: The embeddings projector now lacks a UMAP option, but still works. wchargin-branch: revert-1901
stephanwlee
approved these changes
Apr 3, 2019
cannoneyed
added a commit
to cannoneyed/tensorboard
that referenced
this pull request
Apr 11, 2019
…ensorflow#2091)" This reverts commit 58df24b.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This reverts commit 37c5b50. Manual
merge of
third_party/js.bzlwas required due to #2079; the file is nowidentical to its state prior to #1901.
This is a temporary measure to keep our GitHub-to-Google sync process
green while we work on integrating the
umap-jslibrary into google3.Test Plan:
The embeddings projector now lacks a UMAP option, but still works.
wchargin-branch: revert-1901