Skip to content

Reduce unnecessary fetches in scalar chart #163

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 27, 2017
Merged

Reduce unnecessary fetches in scalar chart #163

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion tensorboard/plugins/scalars/tf_scalar_dashboard/tf-scalar-chart.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -178,6 +178,25 @@
type: Function,
value: () => getRouter().pluginRunTagRoute('scalars', '/scalars'),
},

/*
* A map such that `_loadedRuns[run] === true` iff we've loaded
* `run` already, or are in the process of loading it. This
* exists so that when there are 100 runs selected and the user
* selects an additional run, we only fetch 1 more run instead
* of 101.
*
* `reload` clears this cache.
*
* Equivalently, this is the set of runs for which, after
* callbacks in-flight resolve, the most recent call to
* `setSeriesData(run, data)` on the chart object (a) exists
* and (b) occurred after all reloads so far.
*/
_loadedRuns: {
type: Object,
value: () => ({}),
},
},
observers: [
'reload(tag)',
Expand All @@ -188,6 +207,10 @@
this._changeSeries();
},
reload() {
this._loadedRuns = {};
this._loadData();
},
_loadData() {
if (!this._attached) {
return;
}
Expand All @@ -196,6 +219,10 @@
// prevent race conditions where older data stomps newer data.
this._canceller.cancelAll();
this.runs.forEach(run => {
if (this._loadedRuns[run]) {
return;
}
this._loadedRuns[run] = true;
const url = this._scalarUrl(this.tag, run);
const updateSeries = this._canceller.cancellable(result => {
if (result.cancelled) {
Expand All @@ -214,7 +241,7 @@
},
_changeSeries() {
this.$$('vz-line-chart').setVisibleSeries(this.runs);
this.reload();
this._loadData();
},
redraw() {
this.$$('vz-line-chart').redraw();
Expand Down