Skip to content

Conversation

@laurakwhit
Copy link
Collaborator

Description & motivation 💭

Migrates all +layout.svelte files to Svelte 5 syntax.

Screenshots (if applicable) 📸

Design Considerations 🎨

Testing 🧪

How was this tested 👻

  • Manual testing
  • E2E tests added
  • Unit tests added

Steps for others to test: 🚶🏽‍♂️🚶🏽‍♀️

Checklists

Draft Checklist

Merge Checklist

Issue(s) closed

Docs

Any docs updates needed?

@laurakwhit laurakwhit requested review from a team and rossedfort as code owners October 6, 2025 20:59
@vercel
Copy link

vercel bot commented Oct 6, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
holocene Ready Ready Preview Comment Oct 6, 2025 8:59pm

@laurakwhit laurakwhit merged commit 6cb24de into main Oct 7, 2025
14 checks passed
@laurakwhit laurakwhit deleted the migrate-layout-files-to-svelte5 branch October 7, 2025 17:55
Alex-Tideman pushed a commit that referenced this pull request Oct 8, 2025
* Migrate layout files to Svelte 5

* Update FeedbackButton
Alex-Tideman added a commit that referenced this pull request Oct 8, 2025
* Command palette mvp

* style things

* Add start workflow form

* Try happy

* Make wider, make grid

* Remove form, add top nav shortcut

* POC of query tabs

* Move to own query-tabs component

* Initial setup of query palette

* Edit query ui

* Much better

* Make sticky

* Do some things, svelte5

* Fix up the modal with tags, get everything in a prety good state for the query command. next do query stack

* Fix hover bg

* Make the stack better

* Fix some styles, fix remove filter

* Tone down the modal backdrop

* Move edit query button

* Finish svelte5 migration of filters

* Restyle query list

* Better styles and words

* Fix types

* More fixes

* Final styling touches and add custom label in attribute list

* Remove props, add button

* Make queries per namespace

* Add shareable link

* Better flex

* Remove query tabs

* Fix all the types

* Add disabled to button

* Flip filter list with saved query input

* Move to drawer

* Set fixed width for drawer

* Fix null check in formatListFilterValue

* Icon size, tag color

* Fix padding

* Remove dup start workflow buttons

* Fix font color

* Add back old filtering

* Remove the sidebar, use existing filtering

* Add save/edit/delete view modals

* Fix error in edit modal

* Refactor query stack buttons

* Add task failure count

* More UI stuff

* Move files to refactor

* Continue work on filter list

* Remove count

* Get dropdown chip working

* Fix search shrink issue

* Get saved queries working, need to fix apply filter logic

* Add filter lines icon, fix filtering

* Fix datetime filter

* Remove task failures for now

* Set chipOpenIndex to null afterNavigate

* Remove old files, flex-wrap

* Fix icon padding

* Add unsaved/add filter badges

* Fix boolean, make saved queries stack into buttons with active state

* Switch back to ghost

* Add task failures, make some style tweaks

* Sort saved queries alphabetical

* Add save on click for new view

* Add query management

* Fix unsaved query and add clear all button

* Add unsaved badge

* Fix logic of setting activeQueryView. Still need to figure out adding filters to a system filter

* Add temp state to track pending query so effect is triggered correctly

* Add count of saved views

* Make saved query views expand/collapsable

* Set height for lg/sm screens

* Tone down refresh, bind collapsed state variable

* Add Running system query, make buttons scale smaller

* A little snappier

* Go back to slide

* Fix widths

* Make executionStatus multiselect, disable status option if in use

* Fix refresh rate to once a minute, add timestamp

* Add task failures with mock count

* add system type

* Fix timestamp position, better transitions, tooltip

* Remove tooltip for now

* Add persistStore for savedQueryNavOpen

* Use custom tooltip for saved queries

* Add css variables to make everything line up

* Set height for all screen sizes

* Add maxLength to input, move new query to top of list

* Refactor to use view-modal

* Fix hideModal bug

* min-width on search attribute menu, add integration tests but commented out for now

* Enforce max limit of 20 saved queries

* Add data-testids, get all saved-query specs passing

* More tests for search attributes

* Add tracking to saved query buttons

* Add system vs user in data-track-name

* Remove command palette placement, keep file for later

* Cleanup

* Fix mobile test selector

* Move delete to edit modal view with new footer slot. move count to secondary label

* Fix styles of No Views

* Update more tests

* Bug fixes, add save button

* Fix tests

* Fix filter issues

* Add touched state to not show error if not touched

* Update unit tests

* Fix refresh rate

* Fix refresh counts logic and make backoff less agressive

* Update resfresh rate tests

* Fixes from PR comments

* Remove unused store

* Add text-brand back to chip filter value

* Save as New View

* Update modal title

* Fix default conditional for bool

* Fix NaN in Batch Operations results (#2938)

* Migrate to Svelte 5

* Update text color

* Account for NaN

* Migrate layout files to Svelte 5 (#2937)

* Migrate layout files to Svelte 5

* Update FeedbackButton

* Add step='any' for number input to allow decimals for search attributes

---------

Co-authored-by: Laura Whitaker <[email protected]>
temporal-cicd bot pushed a commit that referenced this pull request Oct 8, 2025
Auto-generated version bump from 2.40.1 to 2.41.0

Bump type: minor

Changes included:
- [`904ca347`](904ca34) fix(workflows): add GitHub App token to version bump PR creation (#2910)
- [`bd50889e`](bd50889) fix(workflows): fix changelog generation and PR body formatting in version bump (#2912)
- [`ce91ecf6`](ce91ecf) style: fix formatting in version-bump workflow (#2914)
- [`352e9f66`](352e9f6) ci(workflows): add path filter to trigger-downstream-updates (#2916)
- [`9e39fa81`](9e39fa8) Add test sentence in README.
- [`68f75a20`](68f75a2) Remove test sentence
- [`73c83894`](73c8389) Start Delay UI improvements (#2907)
- [`f7924cd0`](f7924cd) Fix issue with localActivity decoding with Java sdk (#2921)
- [`474091aa`](474091a) add switch icon (#2895)
- [`a6ec2611`](a6ec261) remove monaco in favor of codemirror (#2920)
- [`b0042390`](b004239) Add quotes around allowOrigins (#2923)
- [`b809fb51`](b809fb5) feat(holocene): add VerticalNav component (#2924)
- [`e72ca8ac`](e72ca8a) Try adding overflow css to codemirror (#2929)
- [`9c472385`](9c47238) add change event to dark mode in top nav (#2930)
- [`bb750c9c`](bb750c9) fix(security): remediate command injection vulnerabilities in GitHub Actions (#2932)
- [`e54f3dc9`](e54f3dc) Add try catch around decodeForSvelte on bad params (#2934)
- [`cfc4998c`](cfc4998) replace v5 with crypto.randomuuid (#2927)
- [`a47970e9`](a47970e) Fix NaN in Batch Operations results (#2938)
- [`6cb24dec`](6cb24de) Migrate layout files to Svelte 5 (#2937)
- [`f424f03d`](f424f03) Bump tar-fs from 3.0.9 to 3.1.1 (#2926)
- [`3255f31d`](3255f31) Saved Workflow Query Views (#2931)
Alex-Tideman added a commit that referenced this pull request Oct 8, 2025
Auto-generated version bump from 2.40.1 to 2.41.0

Bump type: minor

Changes included:
- [`904ca347`](904ca34) fix(workflows): add GitHub App token to version bump PR creation (#2910)
- [`bd50889e`](bd50889) fix(workflows): fix changelog generation and PR body formatting in version bump (#2912)
- [`ce91ecf6`](ce91ecf) style: fix formatting in version-bump workflow (#2914)
- [`352e9f66`](352e9f6) ci(workflows): add path filter to trigger-downstream-updates (#2916)
- [`9e39fa81`](9e39fa8) Add test sentence in README.
- [`68f75a20`](68f75a2) Remove test sentence
- [`73c83894`](73c8389) Start Delay UI improvements (#2907)
- [`f7924cd0`](f7924cd) Fix issue with localActivity decoding with Java sdk (#2921)
- [`474091aa`](474091a) add switch icon (#2895)
- [`a6ec2611`](a6ec261) remove monaco in favor of codemirror (#2920)
- [`b0042390`](b004239) Add quotes around allowOrigins (#2923)
- [`b809fb51`](b809fb5) feat(holocene): add VerticalNav component (#2924)
- [`e72ca8ac`](e72ca8a) Try adding overflow css to codemirror (#2929)
- [`9c472385`](9c47238) add change event to dark mode in top nav (#2930)
- [`bb750c9c`](bb750c9) fix(security): remediate command injection vulnerabilities in GitHub Actions (#2932)
- [`e54f3dc9`](e54f3dc) Add try catch around decodeForSvelte on bad params (#2934)
- [`cfc4998c`](cfc4998) replace v5 with crypto.randomuuid (#2927)
- [`a47970e9`](a47970e) Fix NaN in Batch Operations results (#2938)
- [`6cb24dec`](6cb24de) Migrate layout files to Svelte 5 (#2937)
- [`f424f03d`](f424f03) Bump tar-fs from 3.0.9 to 3.1.1 (#2926)
- [`3255f31d`](3255f31) Saved Workflow Query Views (#2931)

Co-authored-by: Alex-Tideman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants