Skip to content

Allow pending lines to be clickable for Firefox and Safari #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 15, 2025
Merged

Allow pending lines to be clickable for Firefox and Safari #2813

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions src/lib/components/lines-and-dots/svg/timeline-graph-row.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@
$: activityTaskScheduled = group.eventList.find(isActivityTaskStartedEvent);
$: retried =
activityTaskScheduled && activityTaskScheduled.attributes?.attempt > 1;
$: pendingLine = group.isPending || !!pauseTime;
</script>

<g
Expand All @@ -104,6 +105,19 @@
class="relative cursor-pointer"
{height}
>
{#if pendingLine}
{@const width = pauseTime
? points[1] - points[0]
: canvasWidth - 2 * gutter}
<rect
y={y - height / 2}
x={points[0]}
{width}
{height}
fill="transparent"
pointer-events="all"
/>
{/if}
{#each points as x, index}
{@const nextPoint = points[index + 1]}
{@const showText = textIndex === index}
Expand Down
2 changes: 1 addition & 1 deletion src/lib/layouts/workflow-history-layout.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@
{/if}
</div>
</div>
<div class="relative px-2 pb-24 md:px-4 lg:px-8">
<div class="relative select-none px-2 pb-24 md:px-4 lg:px-8">
<div
class="flex flex-wrap items-center justify-between gap-2 bg-off-white/50 py-2 xl:gap-8 dark:bg-space-black/50"
class:sticky-header={!$minimizeEventView}
Expand Down
Loading