Configurable json inclusions in Avro to Json serializing #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchiotludo
requested changes
Aug 28, 2021
Owner
tchiotludo
left a comment
There was a problem hiding this comment.
Mostly good.
Please just add :
- configuration on application.example.yml
- some doc on README.md about this configuration
- minor review ⬆️
| .registerModule(new JavaTimeModule()) | ||
| .registerModule(new Jdk8Module()) | ||
| .setTimeZone(TimeZone.getDefault()); | ||
| System.out.println("Inclusions: " + jsonInclusions); |
Contributor
Author
There was a problem hiding this comment.
Whoops.. done!
|
|
||
| public static String toJson(GenericRecord record) throws IOException { | ||
| Map<String, Object> map = AvroDeserializer.recordDeserializer(record); | ||
| public AvroToJsonSerializer(@Value("${akhq.avro-serializer.json.serialization.inclusions}") @Nullable List<Include> jsonInclusions) { |
Owner
There was a problem hiding this comment.
You are changing the default configuration, please add old default one on the application.yml please
Contributor
Author
There was a problem hiding this comment.
Added the old default to src/main/resources/application.yml
avro-serializer:
json.serialization.inclusions:
- NON_NULL
- NON_EMPTY
Owner
|
Perfect, thanks a lot 👍 |
tchiotludo
pushed a commit
that referenced
this pull request
Oct 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.