fix(log): fix value of content-length always return -1 #2116
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@tchiotludo please review this. this is my mess |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following #1154, the content-lengh displayed is always -1.
This is because the log is evaluated in the OnNext function and this is not the end of the request.
The real end seems to be in "OnComplete".
This also mean the log is now at the end of the request, it was near the end before, so the request time was a little bit off.
Log before :
Log After :
Don't hesitate if i'm being too pushy with all the fix PR, I also can create issues if you want.
I'm just fixing things as I see/need them.