Skip to content

Conversation

shuuji3
Copy link
Contributor

@shuuji3 shuuji3 commented Feb 17, 2024

Hello, this PR fixes two small issues:

  1. Fix the link to a file in the master branch. GitHub web interface can redirect from master to main automatically but some user-agent fails (for example, GitHub Android app). This change ensures that users navigate to the correct page.

  2. Delete the instruction to change _config.yml from translation*.md, which was removed by Eleventy migration and no longer exists (Eleventy migration #269).

@smorimoto smorimoto added the content Related to creating / editing content label Feb 17, 2024
@smorimoto
Copy link
Member

This PR reminds me of the changes in #274 and #312. Maybe we should use HEAD instead of main to make it more robust to future changes.

@ljharb @ctcpip I believe you have any thoughts on this. What do you think?

@ctcpip
Copy link
Member

ctcpip commented Feb 17, 2024

there are differences between them and while I prefer main for a number of reasons for most uses, like the fact that it actually results in links pointing to the tip of main rather than HEAD which will point to a specific commit id, the pattern of using HEAD has been established and it's not a hill I want to die on just yet 😄

@ljharb
Copy link
Member

ljharb commented Feb 17, 2024

I prefer HEAD since it will work regardless of the default branch name; the usability issue @ctcpip mentions exists, and either change is better than the wrong branch name.

@smorimoto
Copy link
Member

Fair enough! I want to unify here whether to use HEAD or branch names. I don't think changes like main becoming the de facto standard will happen often in the future, and I just favor branch names for now. If you all have no major objections to this idea, I will make a change to switch from HEAD to branch names for remaining parts in a subsequent PR.

@smorimoto
Copy link
Member

From my idea above, this PR looks good, at least to me. Thanks a lot! @shuuji3

@ctcpip ctcpip merged commit a395cc7 into tc39:main Feb 22, 2024
@shuuji3 shuuji3 deleted the fix-main-branch-link branch February 22, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

content Related to creating / editing content

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants