Skip to content

Conversation

smorimoto
Copy link
Member

No description provided.

Signed-off-by: Sora Morimoto <[email protected]>
@ctcpip
Copy link
Member

ctcpip commented Apr 18, 2023

I think this is fine, but why not stick with the active LTS for this?

@smorimoto
Copy link
Member Author

I don't have a very strong opinion, but since it's just a runtime for development in a way here, I thought there was no reason to stick to anything too much 🙂

@ljharb
Copy link
Member

ljharb commented Apr 18, 2023

If the intention is to stick to LTS, it shouldn't have 18, it should have lts/* or lts/hydrogen :-)

@ctcpip
Copy link
Member

ctcpip commented Apr 18, 2023

more of an aside than anything else, but for reasons, I always prefer to specify the exact version -- x.y.z

but, I am fine with any of the above for this. will approve as is, but will approve any of these alternatives as well

@smorimoto
Copy link
Member Author

There is no guarantee that CI will always work well with LTS, so I would just specify the major version here 😑 (As you know, the JS ecosystem grows too fast!)

@smorimoto smorimoto merged commit 0f3b882 into main Apr 18, 2023
@smorimoto smorimoto deleted the node20 branch April 18, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants