fix(stylelint): re-order presets correctly #295
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`stylelint-config-prettier-scss` disables all rules that conflict with Prettier. Leave this preset at the bottom so that it can't be overridden. > Make sure to put it **last**, so it will override other configs. Refs: https://github.com/prettier/stylelint-config-prettier-scss#installation Signed-off-by: Derek Lewis <[email protected]>
|
I am unsure if this change introduces anything actionable regarding re-styling, but CI is green, so it seems good to go assuming it is currently set up to lint on PR. /cc @smorimoto |
smorimoto
approved these changes
Aug 19, 2022
|
Good catch! |
|
It would also be nice to add a format check step to CI... |
Yeah, how do you want to handle that? There are a few ways that come to mind… Want to use a GitHub action to determine which formatter to run depending on the file extension or something? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
stylelint-config-prettier-scssdisables all rules that conflictwith Prettier. Leave this preset at the bottom so that it can't be
overridden.
Refs: https://github.com/prettier/stylelint-config-prettier-scss#installation
Signed-off-by: Derek Lewis [email protected]
/cc @smorimoto