fix #221, add structured data (org logo) #289
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: tc39#221 Refs: https://developers.google.com/search/docs/advanced/structured-data/logo Signed-off-by: Derek Lewis <[email protected]>
smorimoto
reviewed
Jul 25, 2022
smorimoto
approved these changes
Jul 25, 2022
|
Co-authored-by: Sora Morimoto <[email protected]>
|
@DerekNonGeneric I agree that OGP support is excellent, but it's worth discussing what should be displayed in OGP, so let's take that out of the scope of this PR. It's more important to make sure we change sure things quickly. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #221
Refs: https://developers.google.com/search/docs/advanced/structured-data/logo
Signed-off-by: Derek Lewis [email protected]
/cc @smorimoto @jasonwilliams