Skip to content

Conversation

smorimoto
Copy link
Member

@smorimoto smorimoto commented Dec 17, 2020

Current progress:

  • intro.yml
  • proposals.yml
  • site.yml
  • stage3.yml

Copy link
Member

@rkirsling rkirsling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!! 🙇

@smorimoto
Copy link
Member Author

smorimoto commented Dec 17, 2020

Note: @sosukesuzuki and @Naturalclar will help me with this PR so they will add some random commits to my fork repository, but that is intended.

@sosukesuzuki
Copy link
Contributor

@Naturalclar Are you already working on stage3.yml?

@Naturalclar
Copy link
Contributor

@sosukesuzuki Not at the moment, feel free to take it 👍

@codehag
Copy link
Collaborator

codehag commented Dec 18, 2020

Amazing, thank you. I am unable to ok the content, can someone send me a ping when this has the all clear? I don't know if everyone has the right privileges. Let me know if anything is needed.

@smorimoto
Copy link
Member Author

smorimoto commented Dec 18, 2020

@rkirsling may be able to review Japanese content. If privilege means the privilege to merge this PR, then probably no one here has it except you. Of course, I will ping you when we make sure that we can merge.

Copy link
Member

@rkirsling rkirsling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm happy to review, I just evidently don't have write access.
Looks like there's one more page to be localized, so I just have one more comment for now.

@smorimoto
Copy link
Member Author

For stage3.yml, I think it would be better to translate only the description section. What do you think? For example, "Top-level await" will lose its meaning when translated.

@smorimoto
Copy link
Member Author

smorimoto commented Dec 20, 2020

I rebased to the latest master.

@smorimoto
Copy link
Member Author

@codehag By the way, the URLs for .at() and Import Assertions are wrong and seem to be broken.

@smorimoto
Copy link
Member Author

@sosukesuzuki Would you still like to tackle this? (This isn't a huge rush btw, but just want to check.)

@sosukesuzuki
Copy link
Contributor

Yes. Sorry for delay. I'll create PR today.

@smorimoto
Copy link
Member Author

smorimoto commented Dec 20, 2020

All right, thanks! No need to apologize :) (Consider your contributions to us as much appreciated, but certainly not demands. Guard your own time carefully.)

sosukesuzuki and others added 3 commits December 22, 2020 02:29
Co-authored-by: Sora Morimoto <[email protected]>
Co-authored-by: Sora Morimoto <[email protected]>
Co-authored-by: Sora Morimoto <[email protected]>
@smorimoto smorimoto changed the title [WIP] Japanese localization Japanese localization Dec 21, 2020
@smorimoto smorimoto requested a review from rkirsling December 21, 2020 17:32
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
@smorimoto
Copy link
Member Author

I think this is already in a mergeable state. The final quality of this is very good, and if no minor problems are found, we can merge this.

Copy link
Member

@rkirsling rkirsling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good aside from a few last comments! 🙂

@smorimoto
Copy link
Member Author

Thanks to everyone who helped me with this PR. I probably couldn't have done such a high-quality translation without your help. (Actually, I'm not very good at Japanese.) And @codehag, this is finally really mergeable. Please merge this when you have time.

@codehag
Copy link
Collaborator

codehag commented Dec 22, 2020

Thank you everyone!

@codehag codehag merged commit 21c51aa into tc39:master Dec 22, 2020
@smorimoto smorimoto deleted the japanese branch December 22, 2020 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants