-
Notifications
You must be signed in to change notification settings - Fork 64
Japanese localization #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this!! 🙇
Note: @sosukesuzuki and @Naturalclar will help me with this PR so they will add some random commits to my fork repository, but that is intended. |
@Naturalclar Are you already working on |
@sosukesuzuki Not at the moment, feel free to take it 👍 |
Amazing, thank you. I am unable to ok the content, can someone send me a ping when this has the all clear? I don't know if everyone has the right privileges. Let me know if anything is needed. |
@rkirsling may be able to review Japanese content. If privilege means the privilege to merge this PR, then probably no one here has it except you. Of course, I will ping you when we make sure that we can merge. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I'm happy to review, I just evidently don't have write access.
Looks like there's one more page to be localized, so I just have one more comment for now.
For |
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Co-authored-by: Ross Kirsling <[email protected]>
Co-authored-by: Sora Morimoto <[email protected]>
Co-authored-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
I rebased to the latest master. |
@codehag By the way, the URLs for |
@sosukesuzuki Would you still like to tackle this? (This isn't a huge rush btw, but just want to check.) |
Yes. Sorry for delay. I'll create PR today. |
All right, thanks! No need to apologize :) (Consider your contributions to us as much appreciated, but certainly not demands. Guard your own time carefully.) |
Co-authored-by: Sora Morimoto <[email protected]>
Co-authored-by: Sora Morimoto <[email protected]>
Co-authored-by: Sora Morimoto <[email protected]>
Co-authored-by: Sora Morimoto <[email protected]>
Co-authored-by: Sora Morimoto <[email protected]>
Co-authored-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Co-authored-by: berlysia <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
I think this is already in a mergeable state. The final quality of this is very good, and if no minor problems are found, we can merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good aside from a few last comments! 🙂
Co-authored-by: Ross Kirsling <[email protected]>
Signed-off-by: Sora Morimoto <[email protected]>
Thanks to everyone who helped me with this PR. I probably couldn't have done such a high-quality translation without your help. (Actually, I'm not very good at Japanese.) And @codehag, this is finally really mergeable. Please merge this when you have time. |
Thank you everyone! |
Current progress:
intro.yml
proposals.yml
site.yml
stage3.yml