fix #205, eliminate mobile navbar space #206
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
09fbcc1 to
3ba654c
Compare
DerekNonGeneric
commented
Jul 30, 2020
_layouts/default.html
Outdated
There was a problem hiding this comment.
This PR is also removing users' ability to zoom out (beyond the initial scale of 1) as this should never be necessary, however, they will still be able to zoom in if they choose to. More information about the topic can be found elsewhere.
minimum-scale The minimum amount the visitor can zoom on the page. 1.0 does not zoom.
As further clarification that this is not a mistake, see the following quote from MDN.
Usage of
user-scalable=nocan cause accessibility issues to users with visual impairments such as low vision.— https://developer.mozilla.org/en-US/docs/Mozilla/Mobile/Viewport_meta_tag#Viewport_basics
This means that we're still good as far as a11y is concerned.
3ba654c to
fa4b330
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes:
https://user-images.githubusercontent.com/17770407/88860772-7e40db00-d1ca-11ea-91c0-173b2bf72d6d.png
https://user-images.githubusercontent.com/17770407/88860773-7ed97180-d1ca-11ea-9c89-7260cfaa8c5f.png
Fixes: #205