Toggle submenu on click menu link text #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also fix the smooth scroll behavior of menu link. |
littledan
reviewed
Jun 19, 2019
littledan
reviewed
Jun 19, 2019
|
@bkardell, could you review this? |
|
@othree - this looks good to me, can you rebase? |
Use css instead of JS to scroll to target Which use less code and can contain navigation history, also make the url in location bar correct.
|
@codehag I have updated the PR. But the CI failed for unknown reason. |
|
I found its prettier check failed issue. Should we run prettier manually? |
|
generally one runs linting/formatting manually. |
|
This looks good now, thanks. Regarding the prettier question, we can bring it up in the website meeting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #146
Didn't call
t.click()because iOS might disable all these kind of operations(js to mimic user interaction) in the future.