Duplicated hover styles to focus #143
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This supports keyboard-only users by replicating the hover states as focus styles. The catch is that the hover states are on the container _and_ the interactive control, necessitating `:focus-within`. Because this selector will kill an entire style for IE users when added into another selector, it warrants its own stand-alone selector (and still leaves IE users unsupported for focus styles). Also, I do not know SASS. So yeah.
|
BTW, if you want to test in your browser dev tools, these are the styles I am trying to get into your SASS files: |
littledan
approved these changes
Mar 20, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This supports keyboard-only users by replicating the hover states as focus styles. The catch is that the hover states are on the container and the interactive control, necessitating
:focus-within. Because this selector will kill an entire style for IE users when added into another selector, it warrants its own stand-alone selector (and still leaves IE users unsupported for focus styles, so there is still a gap). Also, I do not know SASS (woo!).