Tweaked class to current best practice #142
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This better supports wrapping issues that cause pronunciation issues in screen readers.
|
It looks like the author has a lint rule set up that fails if the properties you added are not in alpha order @aardrian |
Per a comment.
|
@bkardell Dinna notice that. Thanks. Had closed the tab to get back to work and missed the big red X as well. |
|
@bkardell I have no idea what this fail is. |
|
Seems like alphabetical order: https://travis-ci.com/tc39/tc39.github.io/builds/104971083#L463 |
|
@aardrian whitespace/width |
|
Move |
|
Yeah, bad at alpha today. And reading Travis issues. And paying attention. Anyway, passed all checks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This better supports wrapping issues that cause pronunciation issues in screen readers.