TC39 orange tweaked to 4.5:1 contrast ratio on white. #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is part of a couple changes to make the orange tags meet WCAG 2.1 contrast requirements per issue tc39#139 .
|
This tweak makes sense to me. In particular, this orange is to be used when the text is light, whereas the other orange is to be used when the text is dark, right? I would suggest naming it tc39-orange-dark, but feel free to leave it as is if you prefer this name. |
I failed to change $tag-spec to include the better contrast orange. It's like I am new.
|
I changed it to |
|
New color preview: |
|
Does the color need to be repeated rather than referencing the new variable? |
|
@littledan I suspect not. I am not a SASS guy, so I defer to you on whether one variable can reference another variable. Happy to edit. |
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part of a couple changes to make the orange tags meet WCAG 2.1 contrast requirements per issue #139 .