Normative: Use HostJobCallbacks for FinalizationRegistry callbacks #2316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
approved these changes
Feb 19, 2021
syg
added a commit
to littledan/html
that referenced
this pull request
Feb 19, 2021
|
We support this, and iirc have already implemented the intended behavior. |
|
(presumably this doesn't need tests because it's not really testable?) |
|
This is not testable in test262, that's right. There can be WPT tests for this, though. |
|
This should be good to merge. |
syg
added a commit
to littledan/html
that referenced
this pull request
Mar 12, 2021
bakkot
approved these changes
Mar 13, 2021
michaelficarra
approved these changes
Mar 16, 2021
…c39#2316) This aligns FinalizationRegistry callbacks with Promise callbacks in allowing web browsers to perform additional steps to save and restore the correct incumbent settings object.
6e8146f to
0635793
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns FinalizationRegistry callbacks with Promise callbacks in
allowing web browsers to perform additional steps to save and restore
the correct incumbent settings object.
Context is that one of the blockers in the HTML integration PR is proper handling of backup incumbent settings objects. I won't recapture that horror here, but we went over it for the Promise machinery and got consensus to add the HostJobCallback machinery. This PR just makes use of that machinery too.
/cc @codehag since Firefox is the only one that implements this behavior. Chrome is interested in aligning with the spec here, but is not prioritizing the implementation work.
(I meant to do this before Stage 4, but I... guess I forgot.)