Fix just_fix_windows_console to use the StreamWrapper #397
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The AnsiToWin32 class is not meant to be used as a file proxy directly, although it does define the write method, but it defines a `stream` member of type StreamWrapper which forwards/intercepts all the file operations as appropriate. In `init` which calls `wrap_stream` this underlying stream object is assigned to sys.stdout/stderr, but the `just_fix_windows_console` function instead assigns the AnsiToWin32 instance directly, which will break trying to use any other methods than `write` on the standard streams. This change fixes the behavior of `just_fix_windows_console` to use the StreamWrapper object as in `init`.
|
I think properly testing this would require a pre-Windows 10 build of windows, so I have not actually tested it. IDK if colorama has some test workflow that would be able to actually verify it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The AnsiToWin32 class is not meant to be used as a file proxy directly, although it does define the write method, but it defines a
streammember of type StreamWrapper which forwards/intercepts all the file operations as appropriate. Ininitwhich callswrap_streamthis underlying stream object is assigned to sys.stdout/stderr, but thejust_fix_windows_consolefunction instead assigns the AnsiToWin32 instance directly, which will break trying to use any other methods thanwriteon the standard streams.This change fixes the behavior of
just_fix_windows_consoleto use the StreamWrapper object as ininit.