Skip to content

Conversation

@shaforostoff
Copy link
Contributor

closes #842

@scotchi scotchi force-pushed the master branch 2 times, most recently from 2948ed7 to de25bc6 Compare September 12, 2019 05:57
@dr0biwan
Copy link

There's an issue with using this patch as-is if the file is CBR & no appropriate header to help determine the file duration can be located.

The following might be more appropriate if (position > length()) position = length(); as clamping to a ~1MB end position prevents the lastFrameOffset related checks in mpegproperties.cpp from working correctly.

@shaforostoff
Copy link
Contributor Author

There's an issue with using this patch as-is if the file is CBR & no appropriate header to help determine the file duration can be located.

i have updated the merge request

@ufleisch
Copy link
Contributor

Please provide instructions on how to reproduce such a freeze. Then we could find the cause why position could become larger than length(), maybe because the APELocation can be wrong?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[patch] avoid freezes reading incomplete mp3 files

3 participants