🦋 Changeset detected

Latest commit: de246e9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Hey @BG-Software-BG - I appreciate your effort in making Tabler even better, but I'd like to raise a two points ... and I hope that doesn't come across the wrong way.

Regarding the main change:
I would give the projects that Tabler is based on (or uses) credits including a link, which is still one of the core principles of the free web.

My bigger concern:
The change to the lock file. There is actually a workflow to prevent these kinds of changes, but it seems that it wasn't updated to reflect the latest filename changes.

I know that you are a long term user and contributor of Tabler, but

• this particular change has nothing to do with the PR, and
• Lock files are something that should be changed only through the core maintainer to maintain security and trust.

I’m always happy to help with reviews! If you’d like, feel free to add me as a reviewer for future PRs.

Hi @kevinpapst

Firstly, I didn't remove those libraries. There is a new docs page for them: https://docs.tabler.io/ui/getting-started/references, which I've linked on the download page to avoid duplication and to only rely on the one source file - open-source.json'. What;'s more, the list in the download.md` was outdated.

Secondly, you might be right that the pnpm-lock.yaml shouldn't have been modified in this PR. However, we've decided, to commit all the changes made in this file.

There is a new docs page for them: https://docs.tabler.io/ui/getting-started/references,

Cool, I didn't know that one. Thanks for sharing!

However, we've decided, to commit all the changes made in this file.

I am actually very cautious when it comes to changes in lock files (Supply Chain Attacks are a real risk), that's why I proposed the CI action to prevent such changes in the first place. And "we" means @codecalm and you? 👍
I actually never noticed that you were part of the Tabler team, sorry!

And "we" means @codecalm and you? 👍

Yes, exactly.

I actually never noticed that you were part of the Tabler team, sorry!

No problem 🙂

@BG-Software-BG - apologies for the confusion, but in this change you add the following comment:

However, the package.json file currently has no such peerDependencies section.
Do you mean this section from core/package.json instead?

@ethancrawford - actually I've changed this note about the peerDependencies, not added.

Previously there was:

For the complete list of supported packages you can check the peerDependencies section in our [package.json](https://github.com/tabler/tabler/blob/dev/package.json)

I didn't check correctness of this sentence, just modified it. It should definitely be changed to avoid confusion. I think that the correct source is the https://github.com/tabler/tabler/blob/dev/core/libs.json file.

actually I've changed this note about the peerDependencies, not added.

Ah yes, sorry, totally missed that 😅