Skip to content

Conversation

wangkanai
Copy link
Contributor

@wangkanai wangkanai commented Aug 31, 2022

Fixed global variable --#{$prefix}card-bg from $dark to $dark-mode-dark. This would also fixed the issue with .btn also, because it effect same underline when switching to dark theme.

image

@vercel
Copy link

vercel bot commented Aug 31, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
tabler ✅ Ready (Inspect) Visit Preview Sep 13, 2022 at 6:46PM (UTC)

@wangkanai
Copy link
Contributor Author

I hope you like this fixed i have made for tabler. everything looks good to go now.

https://tabler-git-fork-wangkanai-card-tabler-ui.vercel.app/form-elements.html?theme=dark

image

@codecalm
Copy link
Member

codecalm commented Aug 31, 2022

nice!

@rjd22 rjd22 requested a review from codecalm September 1, 2022 07:45
@rjd22 rjd22 added the bug Something isn't working label Sep 1, 2022
@wangkanai wangkanai changed the title Fixed .card global variable --#{$prefix}card-bg Fixed global variable for .card and .btn Sep 1, 2022
@wangkanai
Copy link
Contributor Author

wangkanai commented Sep 1, 2022

image

fixed the button issue

image

@wangkanai
Copy link
Contributor Author

I think everything is ready for review and able to merge the PR now. @codecalm @rjd22

@rjd22
Copy link
Collaborator

rjd22 commented Sep 2, 2022

@codecalm could you take a look?

@wangkanai
Copy link
Contributor Author

@codecalm you do not my fixed? Do I need to change anything?

@codecalm
Copy link
Member

@wangkanai cards has #f8fafc bg, instead of #fff - except it, everything looks fine! :)

Screenshot 2022-09-11 at 16 02 42

@wangkanai
Copy link
Contributor Author

wangkanai commented Sep 12, 2022

I have change the color of the card bg, @codecalm please have a look.

image

@codecalm
Copy link
Member

merged, thank you! :)

@wangkanai
Copy link
Contributor Author

I'm happy to help out.
If I find anything else, I keep droping new PR.

Bests,

Sarin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants