-
-
Notifications
You must be signed in to change notification settings - Fork 6.5k
docs: expand sponsors section and remove outdated translations #11771
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe pull request removes Chinese and Korean README translations entirely and restructures the English README's Sponsors section by replacing a single sponsor block with new tiered sponsor sections including Champion, Supporter, Community, and Sponsor categories. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
README-zh_CN.md(0 hunks)README.md(1 hunks)README_ko.md(0 hunks)
💤 Files with no reviewable changes (2)
- README-zh_CN.md
- README_ko.md
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
README.md
216-216: Images should have alternate text (alt text)
(MD045, no-alt-text)
222-222: Images should have alternate text (alt text)
(MD045, no-alt-text)
228-228: Images should have alternate text (alt text)
(MD045, no-alt-text)
234-234: Images should have alternate text (alt text)
(MD045, no-alt-text)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Cloudflare Pages
🔇 Additional comments (1)
README.md (1)
210-234: Well-structured sponsorship tiering system.The new Sponsors section provides clear tier definitions with actionable CTAs for each sponsorship level. The consistent use of
avatarHeight=36across all OpenCollective widgets and the introductory text explaining the value proposition are both well-implemented.
| Become a champion sponsor and get premium technical support from our core contributors. [Become a champion](https://opencollective.com/typeorm) | ||
|
|
||
| Become a gold sponsor and get premium technical support from our core contributors. [Become a gold sponsor](https://opencollective.com/typeorm) | ||
| <a href="https://opencollective.com/typeorm" target="_blank"><img src="https://opencollective.com/typeorm/tiers/gold-sponsor.svg?avatarHeight=36"></a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add alt text to sponsor tier images for accessibility.
The <img> tags lack alt attributes, which is an accessibility requirement for screen readers and is flagged by markdownlint (MD045).
Apply this diff to add descriptive alt text to each sponsor tier image:
-<a href="https://opencollective.com/typeorm" target="_blank"><img src="https://opencollective.com/typeorm/tiers/gold-sponsor.svg?avatarHeight=36"></a>
+<a href="https://opencollective.com/typeorm" target="_blank"><img src="https://opencollective.com/typeorm/tiers/gold-sponsor.svg?avatarHeight=36" alt="Champion sponsors on OpenCollective"></a>
-<a href="https://opencollective.com/typeorm" target="_blank"><img src="https://opencollective.com/typeorm/tiers/love.svg?avatarHeight=36"></a>
+<a href="https://opencollective.com/typeorm" target="_blank"><img src="https://opencollective.com/typeorm/tiers/love.svg?avatarHeight=36" alt="Supporter sponsors on OpenCollective"></a>
-<a href="https://opencollective.com/typeorm" target="_blank"><img src="https://opencollective.com/typeorm/tiers/like.svg?avatarHeight=36"></a>
+<a href="https://opencollective.com/typeorm" target="_blank"><img src="https://opencollective.com/typeorm/tiers/like.svg?avatarHeight=36" alt="Community sponsors on OpenCollective"></a>
-<a href="https://opencollective.com/typeorm" target="_blank"><img src="https://opencollective.com/typeorm/tiers/sponsor.svg?avatarHeight=36"></a>
+<a href="https://opencollective.com/typeorm" target="_blank"><img src="https://opencollective.com/typeorm/tiers/sponsor.svg?avatarHeight=36" alt="Sponsors on OpenCollective"></a>Also applies to: 222-222, 228-228, 234-234
🧰 Tools
🪛 markdownlint-cli2 (0.18.1)
216-216: Images should have alternate text (alt text)
(MD045, no-alt-text)
🤖 Prompt for AI Agents
In README.md around line 216 (also apply same change at lines 222, 228, 234),
the sponsor tier <img> tags are missing alt attributes; update each <img> to
include descriptive alt text (e.g., alt="TypeORM gold sponsor" for the 216 line
and corresponding alt descriptions for the other sponsor tiers) so markdownlint
MD045 and accessibility requirements are satisfied.
gioboa
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👏
Description of change
Expanded sponsors section to show all four OpenCollective tiers:
Removed outdated translation files (README_ko.md, README-zh_CN.md) - not maintained, not referenced in build/CI.
All widgets updated to use avatarHeight=36 parameter.
Pull-Request Checklist
masterbranchFixes #00000N/ASummary by CodeRabbit
Documentation