Skip to content

748 security ensure all containers have no networking #788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Oct 8, 2025
Merged

748 security ensure all containers have no networking #788

merged 6 commits into from
Oct 8, 2025

Conversation

@tyhal
Copy link
Owner

@tyhal tyhal commented Oct 8, 2025

No description provided.

@tyhal tyhal linked an issue Oct 8, 2025 that may be closed by this pull request
[Security] Ensure all containers have no networking #748
Closed
@codecov
Copy link

codecov bot commented Oct 8, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 41.44144% with 65 lines in your changes missing coverage. Please review.
✅ Project coverage is 37.64%. Comparing base (09d9db8) to head (88a615d).
⚠️ Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
pkg/linter/cli/exec/docker.go 4.54% 21 Missing ⚠️
pkg/linter/cli/exec/podman.go 5.88% 16 Missing ⚠️
pkg/linter/cli/exec/linuxpath.go 44.44% 10 Missing ⚠️
pkg/linter/cli/cli.go 30.00% 7 Missing ⚠️
pkg/linter/cli/exec/noop.go 57.14% 4 Missing and 2 partials ⚠️
pkg/linter/cli/exec/host.go 89.28% 2 Missing and 1 partial ⚠️
pkg/crie/execution.go 0.00% 2 Missing ⚠️

❌ Your patch status has failed because the patch coverage (41.44%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #788      +/-   ##
==========================================
+ Coverage   34.35%   37.64%   +3.29%     
==========================================
  Files          26       26              
  Lines        1074     1089      +15     
==========================================
+ Hits          369      410      +41     
+ Misses        654      626      -28     
- Partials       51       53       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mergify
Copy link
Contributor

mergify bot commented Oct 8, 2025 •
edited
Loading

🧪 CI Insights

Here's what we observed from your CI run for 88a615d.

🟢 All jobs passed!

But CI Insights is watching 👀

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 8, 2025

Quality Gate Passed Quality Gate passed

Issues
12 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@tyhal tyhal merged commit 2246f75 into main Oct 8, 2025
13 of 14 checks passed
@tyhal tyhal deleted the 748-security-ensure-all-containers-have-no-networking branch October 19, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Security] Ensure all containers have no networking

2 participants

@tyhal