Fix common errors #764
Merged
Fix common errors #764
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR implements various fixes to improve the codebase, including improved container execution, configuration handling, and parallel execution patterns. The changes address control character handling in Podman output, fix configuration binding issues, and modernize the parallel execution model.
- Fixes stderr/stdout separation in Podman execution using Docker's helper method
- Improves configuration handling by fixing viper config loading and schema references
- Refactors parallel execution to use a worker pool pattern instead of module-based math
- Updates project structure with duplicated options from core instead of external dependencies
Reviewed Changes
Copilot reviewed 25 out of 30 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| script/completions | Script formatting improvements and error handling |
| res/schema/proj.json | Updated JSON schema with restructured configuration options |
| res/schema/lang.json | Cleaned up language schema with renamed types |
| res/completion/crie.bash | Auto-generated bash completion with formatting updates |
| pkg/linter/cli/exec_podman.go | Fixed stderr/stdout handling in Podman execution |
| pkg/crie/linter/reporter_test.go | New test file for reporter functionality |
| pkg/crie/linter/reporter.go | New reporter implementation with worker pool pattern |
| pkg/crie/linter/linter.go | Added GetName helper function |
| pkg/crie/filter_git_test.go | Updated tests to use new Options structure |
| pkg/crie/filter_git.go | Updated to use Options structure and apply ignore filters |
| pkg/crie/filter_dir.go | Added fileListIgnore method and improved filtering |
| pkg/crie/execution_test.go | Updated tests for new Options structure |
| pkg/crie/execution.go | Refactored to use new reporter and Options structure |
| pkg/crie/config.go | Restructured configuration with new Options type |
| img/pip/conf/yaml/.yamllint.yaml | Formatting improvements in YAML lint config |
| crie.yml | New project configuration file |
| cmd/crie/main.go | Fixed viper configuration loading and binding |
| cmd/crie/config/project/config.go | Updated configuration structure and schema references |
| cmd/crie/config/language/defaults.yml | Updated schema reference |
| cmd/crie/config/language/config.go | Updated schema reference |
| cmd/crie/cmd/commands.go | Simplified configuration handling and updated references |
| README.md | Minor documentation formatting fix |
| .github/.goreleaser.yml | Removed extra blank lines |
Files not reviewed (3)
- .idea/jsonSchemas.xml: Language not supported
- .idea/runConfigurations/crie_schema_language.xml: Language not supported
- .idea/runConfigurations/crie_schema_project.xml: Language not supported
Comments suppressed due to low confidence (1)
script/completions:14
- [nitpick] The redirections lack space before
>which is inconsistent with common shell scripting style. Consider adding spaces:> res/completion/crie.zsh.
$CRIE_BIN completion zsh >res/completion/crie.zsh
$CRIE_BIN completion bash >res/completion/crie.bash
$CRIE_BIN completion fish >res/completion/crie.fish
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #764 +/- ##
==========================================
+ Coverage 28.65% 34.45% +5.80%
==========================================
Files 27 26 -1
Lines 1047 1071 +24
==========================================
+ Hits 300 369 +69
+ Misses 699 652 -47
- Partials 48 50 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🧪 CI InsightsHere's what we observed from your CI run for ddabc49. 🟢 All jobs passed!But CI Insights is watching 👀 |
Split stderr and stdout in podman using dockers helper method to avoid printing control characters Fix ignore not being passed through Fix viper config not working Update parallel execution to use workers instead of module math Have project options duplicated from crie core instead useit
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split stderr and stdout in podman using dockers helper method to avoid printing control characters Fix ignore not being passed through
Fix viper config not working
Update parallel execution to use workers instead of module math Have project options duplicated from crie core instead useit