fix: preserve account order in get_multiple_accounts_with_remote_fallback
#367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
getMultipleAccounts
RPC endpoint was returning accounts in incorrect order when mixing local and remote results. The bug was in the underlyingget_multiple_accounts_local_then_remote
method, which was appending all found accounts first, then all remote accounts, breaking the original request order.Root cause:
get_multiple_accounts_local_then_remote
split results into found/missing arrays[all_found, all_remote]
instead of preserving original orderChanges:
get_multiple_accounts_local_then_remote → get_multiple_accounts_with_remote_fallback
Implementation:
This fixes the issue at the source, benefiting all callers of the method, and ensures the response array matches the request array order exactly as required by the Solana RPC specification.