fix: parse inner instructions with proper account keys in simulateTransaction
#365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nsaction The simulateTransaction RPC endpoint was returning inner instructions in raw CompiledInstruction format instead of the parsed UiInstruction format expected by Web3.js clients. This caused deserialization errors when clients tried to process the response. Changes: - Updated transform_tx_metadata_to_ui_accounts to accept transaction message and loaded addresses for proper account key resolution - Used parse_ui_inner_instructions to convert CompiledInstruction to UiInstruction format with account keys from both static accounts and ALTs - Updated get_simulate_transaction_result to pass message and loaded addresses - Ensured proper handling of Address Lookup Tables in v0 transactions This matches the behavior of the official Solana validator and fixes compatibility with Web3.js TypeScript client.
|
Thanks for your contribution @serejke 🙏 |
lgalabru
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
simulateTransactionRPC endpoint was returning inner instructions in rawCompiledInstructionformat instead of the parsedUiInstructionformat expected by Web3.js clients. This caused deserialization errors when clients tried to process the response.See for more details:
solana-foundation/solana-com#844
Changes:
transform_tx_metadata_to_ui_accountsto accept transaction message and loaded addresses for proper account key resolutionparse_ui_inner_instructionsto convertCompiledInstructiontoUiInstructionformat with account keys from both static accounts and ALTsget_simulate_transaction_resultto pass message and loaded addressesThis matches the behavior of the official Solana validator and fixes compatibility with Web3.js TypeScript client.