Add Array Monoid & Group. #356
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
There was a problem hiding this comment.
can you add tests using monoidLaws and groupLaws for commutative and non-commutative cases? An example non-commutative monoid would be String (I am not sure we actually have any non-commutative groups implemented, but for fun you could do quaternions).
Collaborator
|
Here is an example: You should always have two kinds of tests: 1) show the logic works as you claim it does (in this case like .zip with padding then pointwise addition). 2) that the monoid/group/ring laws are satisfied. Part 2 is already done for you, you just need to call the correct methods. |
Added a monoidLaws test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding monoid & group for arrays.
The monoid takes the provided arrays and does pair-wise addition of the elements. If one array is longer than the other, the result is longer.size in length with the items from the longer copied over. zero returns an empty Array.
The group extends the monoid and implements negation by calling negate on the individual items of the array.