Skip to content

Conversation

@johnynek
Copy link
Collaborator

No description provided.

@johnynek
Copy link
Collaborator Author

review @lrytz ?

@ianoc ?

@johnynek
Copy link
Collaborator Author

this fixes up #643 as part of #640

@codecov-io
Copy link

codecov-io commented Sep 14, 2017

Codecov Report

Merging #645 into develop will increase coverage by 0.08%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #645      +/-   ##
===========================================
+ Coverage    82.32%   82.41%   +0.08%     
===========================================
  Files          111      111              
  Lines         5189     5204      +15     
  Branches       467      467              
===========================================
+ Hits          4272     4289      +17     
+ Misses         917      915       -2
Impacted Files Coverage Δ
.../main/scala/com/twitter/algebird/Successible.scala 87.5% <0%> (-4.17%) ⬇️
.../main/scala/com/twitter/algebird/JavaMonoids.scala 62.9% <0%> (-1.62%) ⬇️
...c/main/scala/com/twitter/algebird/MapAlgebra.scala 76.69% <0%> (-0.98%) ⬇️
.../main/scala/com/twitter/algebird/BloomFilter.scala 95.65% <0%> (+3.04%) ⬆️
...in/scala/com/twitter/algebird/scalacheck/Gen.scala 100% <0%> (+8.33%) ⬆️
...src/main/scala/com/twitter/algebird/Interval.scala 88.69% <0%> (+9.56%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bae679c...95d7b8e. Read the comment docs.

@ianoc
Copy link
Collaborator

ianoc commented Sep 14, 2017

lgtm

@johnynek johnynek merged commit 063090a into develop Sep 14, 2017
@johnynek johnynek deleted the oscar/fix-212-opt branch September 14, 2017 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants