Add MonoidAggregator.collectBefore #611
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 82.33% (diff: 100%)@@ develop #611 diff @@
==========================================
Files 110 110
Lines 5109 5113 +4
Methods 4650 4653 +3
Messages 0 0
Branches 459 460 +1
==========================================
+ Hits 4157 4210 +53
+ Misses 952 903 -49
Partials 0 0
|
Collaborator
Author
|
+53 hits, -49 misses! That's the way you do it! :) Only 903 lines left to test to get to 100% coverage! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adds
collectBeforeto MonoidAggregator.Also too a moment to increase Aggregator test coverage, which is nice. Thanks to this plugin for helping me find untested methods:
https://chrome.google.com/webstore/detail/codecov-extension/keefkhehidemnokodkdkejapdgfjmijf