Add tests for generated tuple/product aggregators #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sritchie
commented
Nov 29, 2016
| # Example: "T,U" | ||
| type_values_commaed = TYPE_SYMBOLS.first(n).join(", ") | ||
| "class Tuple#{n}#{algebraic_structure.capitalize}[#{type_values_commaed}](implicit #{get_type_parameters(n, algebraic_structure)}) extends #{algebraic_structure.capitalize}[(#{type_values_commaed})]" | ||
| extends = ["#{algebraic_structure.capitalize}[(#{type_values_commaed})]"] |
Collaborator
Author
There was a problem hiding this comment.
everything except for this change is a formatting thing that removes the extra space before :. Strange that the checked-in script didn't generate the checked-in code, by the way.
Collaborator
There was a problem hiding this comment.
What I think it is: code formatting has run on the code.
Current coverage is 72.90% (diff: 100%)@@ develop #585 diff @@
==========================================
Files 111 111
Lines 4572 4425 -147
Methods 4154 4009 -145
Messages 0 0
Branches 379 377 -2
==========================================
+ Hits 2945 3226 +281
+ Misses 1627 1199 -428
Partials 0 0
|
johnynek
reviewed
Nov 29, 2016
Collaborator
johnynek
left a comment
There was a problem hiding this comment.
This is so great! Thanks Sam!
| # Example: "T,U" | ||
| type_values_commaed = TYPE_SYMBOLS.first(n).join(", ") | ||
| "class Tuple#{n}#{algebraic_structure.capitalize}[#{type_values_commaed}](implicit #{get_type_parameters(n, algebraic_structure)}) extends #{algebraic_structure.capitalize}[(#{type_values_commaed})]" | ||
| extends = ["#{algebraic_structure.capitalize}[(#{type_values_commaed})]"] |
Collaborator
There was a problem hiding this comment.
What I think it is: code formatting has run on the code.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increases our coverage for the worst offenders in
algebird-core- the generated product and tuple aggregators.I've also modified the generation script so that each data structure extends its parent. This reduces duplication and allows us to test ALL methods with
ringLawsalone.The inheritance doesn't break binary compatibility.