Skip to content

Fixes #549 - Use repartition instead of coalesce for compat with spark 2 #550

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 23, 2016
Merged

Fixes #549 - Use repartition instead of coalesce for compat with spark 2 #550

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions algebird-spark/src/main/scala/com/twitter/algebird/spark/AlgebirdRDD.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ class AlgebirdRDD[T](val rdd: RDD[T]) extends AnyVal {
Iterator(agg.appendAll(b, data))
}
}, preservesPartitioning = true)
pr.coalesce(1, shuffle = true)
pr.repartition(1)
.mapPartitions(pr => Iterator(agg.semigroup.sumOption(pr)))
.collect.head.map(agg.present)
}
Expand Down Expand Up @@ -112,7 +112,7 @@ class AlgebirdRDD[T](val rdd: RDD[T]) extends AnyVal {

// my reading of the docs is that we do want a shuffle at this stage to
// to make sure the upstream work is done in parallel.
val results = partialReduce.coalesce(1, shuffle = true).mapPartitions({ it =>
val results = partialReduce.repartition(1).mapPartitions({ it =>
Iterator(sg.sumOption(it))
}, preservesPartitioning = true)
.collect
Expand Down