Pzheng/gaussian euclidean #448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
There was a problem hiding this comment.
might be nice to add a method like:
def sample(r: java.util.Random): Doubleto get a sample from this distribution.
Contributor
There was a problem hiding this comment.
Or possibly take it further and integrate with https://github.com/jliszka/probability-monad
Collaborator
There was a problem hiding this comment.
I actually have some code internal to Twitter that has this as well as some bootstrap and chernov/hoeffding-bound based randomized testing. I should release that (and perhaps make it work with the the code above rather than mine which is just a Reader monad on java.util.Random).
Collaborator
|
Thanks for doing this! Just some minor cleanups requested. |
Collaborator
There was a problem hiding this comment.
actually, this should be a method on the case class, and it should be scaled:
mean + r.nextGaussian() * stddev
Collaborator
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add gaussian distribution monoid