Skip to content

Conversation

@avibryant
Copy link
Contributor

An Aggregator that wraps the EventuallySemigroup (and one for EventuallyMonoid), as well as a SetSizeAggregator that starts with a Set and ends with a HLL.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it might make sense to make the default maxSetSize to be something that depends on hllBits. At the extreme you could serialize every item coming in and increment a byte counter (although the in-memory may be much less or more, but still), then when it exceeds 2^hllBits, switch over. I would think something like maxSetSize: Int = math.max(10, 1 << (hllBits - 5)) might be a decent default.

@johnynek
Copy link
Collaborator

This looks great, but you're pushing our test coverage down here. Can we get at least a simple test to exercise this a bit?

Also, can you add some comments to the type so the scaladoc is not bare?

@johnynek
Copy link
Collaborator

ping for at least a test or two that exercises this.

@johnynek
Copy link
Collaborator

ping again for a test.

@avibryant
Copy link
Contributor Author

Sorry, been busy - I'll try to get one in, but there's always the next release.

@johnynek
Copy link
Collaborator

@DanielleSucher thanks for the tests!

johnynek added a commit that referenced this pull request Apr 13, 2015
@johnynek johnynek merged commit 062f560 into twitter:develop Apr 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants