-
Notifications
You must be signed in to change notification settings - Fork 587
Web client: sort ServiceWorker filesToCache #9034
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Web client: sort ServiceWorker filesToCache #9034
Conversation
Update: I've been able to build from 25543d3 successfully, and can confirm that the resulting Snippet from: build/sw.js function filesToCache(){return["app.js","app.js.map","argon2.wasm","calendar-view-CBFsQcb-.js","calendar-view-CBFsQcb-.js.map","common-DlxDDhNq.js","common-DlxDDhNq.js.map","common-min-DDW5MDcN.js","common-min-DDW5MDcN.js.map","contacts-BqxphGlM.js","contacts-BqxphGlM.js.map","date-gui-bJRihSj5.js","date-gui-bJRihSj5.js.map","date-li3obA6P.js","date-li3obA6P.js.map","gui-base-C6SJ01OE.js","gui-base-C6SJ01OE.js.map","images/font.ttf","images/logo-favicon-152.png","images/logo-favicon-196.png","images/logo-favicon.png","index.html","index.js","invoice-gh1Kkh5t.js","invoice-gh1Kkh5t.js.map","jszip-Bnh3tOTf.js","jszip-Bnh3tOTf.js.map","liboqs.wasm","linkify-BTj9bcKs.js","linkify-BTj9bcKs.js.map","login--XcUoZYf.js","login--XcUoZYf.js.map","mail-editor-Dx3qhEhD.js","mail-editor-Dx3qhEhD.js.map","mail-settings-D-h0tcr-.js","mail-settings-D-h0tcr-.js.map","mail-view-Kvd81Yxo.js","mail-view-Kvd81Yxo.js.map","mail-worker.js","mail-worker.js.map","main-Ds4pTBi_.js","main-Ds4pTBi_.js.map","native-common-DiGDsPub.js","native-common-DiGDsPub.js.map","polyfill-helpers-TovMs9th.js","polyfill-helpers-TovMs9th.js.map","polyfill.js","sanitizer-yYY4lZnw.js","sanitizer-yYY4lZnw.js.map","search-Cav5f4Fz.js","search-Cav5f4Fz.js.map","settings-CbCPOO1D.js","settings-CbCPOO1D.js.map","setup-wizard-CXwcgznQ.js","setup-wizard-CXwcgznQ.js.map","sharing-CaM4DOLx.js","sharing-CaM4DOLx.js.map","translation-en-DtEYnBUF.js","translation-en-DtEYnBUF.js.map","ui-extra-Cpn0cHmH.js","ui-extra-Cpn0cHmH.js.map","wasm-BAPiWBZ7.js","wasm-BAPiWBZ7.js.map","wasm-fallback-D-anRYZf.js","wasm-fallback-D-anRYZf.js.map","worker-bootstrap.js","worker-lazy-CVYxmNc-.js","worker-lazy-CVYxmNc-.js.map","worker-search-CgUo851E.js","worker-search-CgUo851E.js.map"]}...however, I have not yet tested the resulting webapp. |
I would have liked to confirm that some of the
It's far from comprehensive testing, but based on these I'm ready to mark this pull request as ready for review. |
This is intended to support build reproducibility[1], providing a deterministic ordering (provided that the filenames themselves are produced deterministically by RollUp, which I believe they are). Relates-to issue tutao#8154 [1] - https://reproducible-builds.org
25543d3 to
a488df1
Compare
This is intended to support build reproducibility, providing a deterministic ordering (provided that the filenames themselves are produced deterministically by RollUp, which I believe they are) for the
filesToCachelist in the ServiceWorker script file.Although I'm relatively confident in this fix, I haven't been able to build/test it locally yet, so I'm opening this PR in draft status.
May resolve #1016.