Scopes enhancements #135
Merged
Scopes enhancements #135
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 17, 2015
tests/Entity/Post/Comment.php
Outdated
Collaborator
There was a problem hiding this comment.
You should use new \DateTime('yesterday') instead of date('Y-m-d H:i:s', strtotime('yesterday')) here so the database adapter can format the DateTime object however it needs to for comparison. Also, it's less typing :).
Collaborator
|
Looks good. I'll check the noQuote issue in a separate issue/PR. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mapper now defaults to entities' scopes instead of empty array. The method
scopeswas already defined in Entity, but I don't think it was used from what I saw in the code.Scopes can be used from relations: