ClassDef should return last element of class #9778
Open
+218
−215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This doesn't actually matter for us, because we don't allow putting a sig on a `<static-init>` and thus you can't actually use the result of evaluating a class def. But I'm working on a change that removes class_flatten, and it's easier to model the "true" Ruby behavior where the last thing is returned, than it is to model the current behavior. So for the sake of showing the change to the exp files, I want to make this as a separate change.
c356825 to
c915c73
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This doesn't actually matter for us, because we don't allow putting a sig
on a
<static-init>and thus you can't actually use the result ofevaluating a class def.
But I'm working on a change that removes class_flatten, and it's easier to
model the "true" Ruby behavior where the last thing is returned, than it is
to model the current behavior. So for the sake of showing the change to the
exp files, I want to make this as a separate change.
Test plan
See included automated tests.