RSpec.describe with experimental flag #9484
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for RSpec.describe to inherit from RSpec::Core::ExampleGroup. This allows before hooks and other test methods to access RSpec DSL methods like expect, subject, is_expected, etc. Based on prior work that was backed out in commit 5276b75. Committed-By-Agent: claude
This flag controls whether RSpec.describe will be transformed to inherit from RSpec::Core::ExampleGroup. When disabled (default), RSpec.describe behaves like a regular describe call. This allows users to opt-in to experimental RSpec support while keeping the default behavior unchanged. Committed-By-Agent: claude
The experimentalRSpecEnabled flag was being set in Options but not copied to GlobalState, so the rewriter couldn't see it. This caused RSpec.describe to not be recognized even when --enable-experimental-rspec was set. Committed-By-Agent: claude
Allow RSpec.shared_examples, RSpec.shared_context, and RSpec.shared_examples_for to be used at the top level (outside of describe blocks) when the --enable-experimental-rspec flag is enabled. This mirrors the RSpec.describe support and uses the same isRSpec check. Committed-By-Agent: claude
jez
requested changes
Oct 22, 2025
There was a problem hiding this comment.
Do you mean for rspec_describe__experimental.rb and rspec_describe.rb to be typechecked in one unit?
filenames that have a __ in them are special. look for files named like __1.rb and __2.rb for more examples
We need to either:
- rename
rspec_describe.rb→rspec_describe__stable.rb, or - rename
rspec_describe__experimental.rb→rspec_describe_experimental.rb
There was a problem hiding this comment.
Ah no, I meant for them to be separate tests – one with the experimental flag and no type errors, and one without the flag and with errors. I'll delete this anyways since we won't ship with a flag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal of this PR is to activate
RSpectyping behind a feature flag.Specifically, it makes it so with the flag,
RSpec.describewill ensure thatRSpec::Core::ExampleGroupAPI is available in the nesteditblocks.