HttpTask support auth when has userinfo #1554
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Barenboim
reviewed
May 16, 2024
src/factory/HttpTaskImpl.cc
Outdated
|
|
||
| this->WFComplexClientTask::set_transport_type(is_ssl ? TT_TCP_SSL : TT_TCP); | ||
| client_req->set_request_uri(request_uri.c_str()); | ||
| client_req->set_header_pair("Host", header_host.c_str()); |
Contributor
There was a problem hiding this comment.
遇到重定向，好像没有清除这个Header。还有个问题，就是重定向失败，也需要清除。目前重定向失败是有清除Host的。
Contributor
Author
There was a problem hiding this comment.
这种情况下清除header的目的是什么呢，这个header有可能是用户设置的
Contributor
There was a problem hiding this comment.
重定向还不清除？重定向可能会有新的userinfo吧。
Contributor
Author
There was a problem hiding this comment.
遇到重定向，好像没有清除这个Header。还有个问题，就是重定向失败，也需要清除。目前重定向失败是有清除Host的。
两个问题
遇到重定向，好像没有清除这个Header
重定向需要清除这个header，同时应清除Cookie等其他敏感信息，分两种情况
- 同站重定向时，通常仍需这个认证，清除后只是会另用户困惑，不会有安全风险
- 跨站重定向时，需要清除以避免泄露信息
还有个问题，就是重定向失败，也需要清除
这种情况下清除header的目的是什么呢，这个header有可能是用户设置的
Barenboim
reviewed
May 17, 2024
src/factory/HttpTaskImpl.cc
Outdated
| else | ||
| portb = strcasecmp(b.scheme, "http") == 0 ? 80 : 443; | ||
|
|
||
| return strcasecmp(a.scheme, b.scheme) == 0 && |
Contributor
There was a problem hiding this comment.
我感觉是不是咱们只要判断host部分相同就是可以了？如果一个站点从http redirect到https，是不是应该认为还是同一个站？
Contributor
Author
There was a problem hiding this comment.
有道理，端口不参与域名解析，可以认为同一个host名表示同一个服务主体
kedixa
commented
May 28, 2024
kedixa
added a commit
to kedixa/workflow
that referenced
this pull request
May 28, 2024
Barenboim
pushed a commit
that referenced
this pull request
May 28, 2024
* HttpTask support auth when has userinfo * remove one StringUtil::url_decode as requested in #1554
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.