Facilitate programmatic use of filter settings #905
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add filter setting to the API and allow it to be set from application context * create default filter setting implementation and deprecate current filter settings * remove internal ParameterAccessor since it was mostly made redundant by GlobalParamsLookup * allow client to individually set filter settings instead of forcing client to set all filter settings * remove references to Registry from GlobalParamsLookup since it made construction of the latter awkward * standardise log messages * rename ResourceConfigSeqLookup to GlobalResourceConfigSeqLookup; might break clients though I doubt that this is being referenced test: assert that the pipeline termination error bubbles up to the caller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test: assert that the pipeline termination error bubbles up to the caller