Skip to content

Conversation

sorin-silaghi
Copy link
Contributor

@tfennelly
Copy link
Member

Hey Sorin.

I tried merging this into upstream, but there are 2 issues:

  1. The test is not in the right branch in the source tree. They're in edi/edisax/parser/src/test/ but should be in edi/edisax/src/test/. Not sure how you were able to run all the tests.
  2. After moving the test I get the failure listed here: https://gist.github.com/1234215

@sorin-silaghi
Copy link
Contributor Author

Hi Tom,

            Sorry I wasn't sure about where to add that and I can't spot

the location you mentioned in the way eclipse opens the project. In any case
the result seems ok to me, it's just that it's missing the empty tags
( seems to be the problem). If you could just remove
those it should work.

best regards,
Sorin.

On Thu, Sep 22, 2011 at 9:56 AM, Tom Fennelly <
[email protected]>wrote:

Hey Sorin.

I tried merging this into upstream, but there are 2 issues:

  1. The test is not in the right branch in the source tree. They're in
    edi/edisax/parser/src/test/ but should be in edi/edisax/src/test/. Not sure
    how you were able to run all the tests.

  2. After moving the test I get the failure listed below:

    Expected:

    [1245?1245'12456]
    Actual:

    [1245?1245'12456]

Reply to this email directly or view it on GitHub:
#43 (comment)

@sorin-silaghi
Copy link
Contributor Author

I moved the test case and fixed it. Everything should be ok now.

@tfennelly
Copy link
Member

pushed upstream

@tfennelly tfennelly closed this Mar 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants