Skip to content

feat: Support VM HA #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: Support VM HA #90

wants to merge 1 commit into from

Conversation

carezkh
Copy link
Contributor

@carezkh carezkh commented Apr 20, 2023

No description provided.

@carezkh carezkh force-pushed the care-dev-vm-ha branch 2 times, most recently from dc00254 to abb890d Compare April 21, 2023 06:13
@codecov
Copy link

codecov bot commented Apr 21, 2023 •
edited
Loading

Codecov Report

Attention: Patch coverage is 1.90275% with 464 lines in your changes missing coverage. Please review.

Project coverage is 27.83%. Comparing base (6bdf25a) to head (94f9db2).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
pkg/controller/lockspace_controller.go 0.00% 377 Missing ⚠️
pkg/controller/vm_controller.go 2.24% 83 Missing and 4 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   34.11%   27.83%   -6.29%     
==========================================
  Files           6        7       +1     
  Lines        1952     2425     +473     
==========================================
+ Hits          666      675       +9     
- Misses       1182     1642     +460     
- Partials      104      108       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚨 Try these New Features:

@carezkh carezkh force-pushed the care-dev-vm-ha branch 2 times, most recently from 17ea008 to afbc998 Compare April 21, 2023 07:47
@carezkh carezkh requested a review from fengye87 April 21, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fengye87 fengye87 Awaiting requested review from fengye87

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@carezkh