Skip to content

Conversation

@smst-jeff
Copy link
Contributor

This PR refactors the code to shutdown the services concurrently and return the first error instead of doing that sequentially.

@smst-jeff smst-jeff requested review from a team and maraino July 24, 2025 03:43
@github-actions github-actions bot added the needs triage Waiting for discussion / prioritization by team label Jul 24, 2025
@smst-jeff smst-jeff force-pushed the jeff/use-errgroup-for-shutdown branch from ca168f1 to 6aaaa77 Compare July 24, 2025 17:28
@smst-jeff smst-jeff merged commit 2a51f17 into master Jul 24, 2025
12 checks passed
@smst-jeff smst-jeff deleted the jeff/use-errgroup-for-shutdown branch July 24, 2025 17:29
@hslatman hslatman added this to the v0.28.5 milestone Jul 28, 2025
njunot pushed a commit to njunot/certificates that referenced this pull request Sep 5, 2025
njunot pushed a commit to njunot/certificates that referenced this pull request Sep 5, 2025
liujed pushed a commit to liujed/caddy-dns01proxy that referenced this pull request Dec 6, 2025
…o_modules group across 1 directory (#17)

Bumps the go_modules group with 1 update in the / directory:
[github.com/smallstep/certificates](https://github.com/smallstep/certificates).

Updates `github.com/smallstep/certificates` from 0.28.4 to 0.29.0
<details>
<summary>Release notes</summary>
<p><em>Sourced from <a
href="https://github.com/smallstep/certificates/releases">github.com/smallstep/certificates's
releases</a>.</em></p>
<blockquote>
<h2>Step CA v0.29.0 (25-12-03)</h2>
<h2>Official Release Artifacts</h2>
<h4>Linux</h4>
<ul>
<li>📦 <a
href="https://dl.smallstep.com/gh-release/certificates/gh-release-header/v0.29.0/step-ca_linux_0.29.0_amd64.tar.gz">step-ca_linux_0.29.0_amd64.tar.gz</a></li>
<li>📦 <a
href="https://dl.smallstep.com/gh-release/certificates/gh-release-header/v0.29.0/step-ca_0.29.0-1_amd64.deb">step-ca_0.29.0-1_amd64.deb</a></li>
<li>📦 <a
href="https://dl.smallstep.com/gh-release/certificates/gh-release-header/v0.29.0/step-ca-0.29.0-1.x86_64.rpm">step-ca-0.29.0-1.x86_64.rpm</a></li>
<li>📦 <a
href="https://dl.smallstep.com/gh-release/certificates/gh-release-header/v0.29.0/step-ca_0.29.0-1_arm64.deb">step-ca_0.29.0-1_arm64.deb</a></li>
<li>📦 <a
href="https://dl.smallstep.com/gh-release/certificates/gh-release-header/v0.29.0/step-ca-0.29.0-1.aarch64.rpm">step-ca-0.29.0-1.aarch64.rpm</a></li>
</ul>
<h4>OSX Darwin</h4>
<ul>
<li>📦 <a
href="https://dl.smallstep.com/gh-release/certificates/gh-release-header/v0.29.0/step-ca_darwin_0.29.0_amd64.tar.gz">step-ca_darwin_0.29.0_amd64.tar.gz</a></li>
<li>📦 <a
href="https://dl.smallstep.com/gh-release/certificates/gh-release-header/v0.29.0/step-ca_darwin_0.29.0_arm64.tar.gz">step-ca_darwin_0.29.0_arm64.tar.gz</a></li>
</ul>
<h4>Windows</h4>
<ul>
<li>📦 <a
href="https://dl.smallstep.com/gh-release/certificates/gh-release-header/v0.29.0/step-ca_windows_0.29.0_amd64.zip">step-ca_windows_0.29.0_amd64.zip</a></li>
</ul>
<p>For more builds across platforms and architectures, see the
<code>Assets</code> section below.
And for packaged versions (Docker, k8s, Homebrew), see our <a
href="https://smallstep.com/docs/step-ca/installation">installation
docs</a>.</p>
<p>Don't see the artifact you need? Open an issue <a
href="https://github.com/smallstep/certificates/issues/new/choose">here</a>.</p>
<h2>Signatures and Checksums</h2>
<p><code>step-ca</code> uses <a
href="https://github.com/sigstore/cosign">sigstore/cosign</a> for
signing and verifying release artifacts.</p>
<p>Below is an example using <code>cosign</code> to verify a release
artifact:</p>
<pre><code>cosign verify-blob \
  --certificate step-ca_darwin_0.29.0_amd64.tar.gz.pem \
  --signature step-ca_darwin_0.29.0_amd64.tar.gz.sig \
--certificate-identity-regexp
&quot;https://github\.com/smallstep/workflows/.*&quot; \
--certificate-oidc-issuer https://token.actions.githubusercontent.com \
  step-ca_darwin_0.29.0_amd64.tar.gz
</code></pre>
<p>The <code>checksums.txt</code> file (in the <code>Assets</code>
section below) contains a checksum for every artifact in the
release.</p>
<h2>Changelog</h2>
<ul>
<li>992ff696e95b424a99140bd7edb2144013975059 Merge pull request <a
href="https://redirect.github.com/smallstep/certificates/issues/2491">#2491</a>
from smallstep/mariano/update</li>
<li>9d79c59c1d0afdc235047e4509f79564bb0bd9a0 Merge branch 'master' into
mariano/update</li>
<li>8e76e290c0e37f09d13660ed2d5c8b01e80377d6 Disable govulncheck until
go 1.25.5 is available in github actions (<a
href="https://redirect.github.com/smallstep/certificates/issues/2490">#2490</a>)</li>
<li>1011f5f5408b470a636f583bf74c0d7bbaf75d72 Improve validation in
authorization path</li>
<li>48ed3a5d17d1224377d3a36d8e1a67575340c493 Changelog updates for
preparing for v0.29.0 (<a
href="https://redirect.github.com/smallstep/certificates/issues/2488">#2488</a>)</li>
<li>008e6ae94aa641c1350d84d0860c428f05dd444c Merge pull request <a
href="https://redirect.github.com/smallstep/certificates/issues/2487">#2487</a>
from
smallstep/dependabot/github_actions/softprops/action-gh-release-2.5.0</li>
<li>895e8c61bfbeda9baed298ba2350a9b1b59cd122 Bump
softprops/action-gh-release from 2.4.2 to 2.5.0</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/smallstep/certificates/blob/master/CHANGELOG.md">github.com/smallstep/certificates's
changelog</a>.</em></p>
<blockquote>
<h2>[0.29.0] - unreleased</h2>
<h3>Added</h3>
<ul>
<li><code>smallstep/certificates#2370</code></li>
<li><code>smallstep/certificates#2382</code></li>
<li><code>smallstep/certificates#2408</code></li>
<li><code>smallstep/certificates#2461</code></li>
<li><code>smallstep/certificates#2463</code></li>
</ul>
<h3>Changed</h3>
<ul>
<li><code>smallstep/certificates#2343</code></li>
</ul>
<h3>Deprecated</h3>
<h3>Removed</h3>
<h3>Fixed</h3>
<ul>
<li><code>smallstep/certificates#2338</code></li>
<li><code>smallstep/certificates#2435</code></li>
<li><code>smallstep/certificates#2444</code></li>
</ul>
<h3>Security</h3>
</blockquote>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/smallstep/certificates/commit/992ff696e95b424a99140bd7edb2144013975059"><code>992ff69</code></a>
Merge pull request <a
href="https://redirect.github.com/smallstep/certificates/issues/2491">#2491</a>
from smallstep/mariano/update</li>
<li><a
href="https://github.com/smallstep/certificates/commit/9d79c59c1d0afdc235047e4509f79564bb0bd9a0"><code>9d79c59</code></a>
Merge branch 'master' into mariano/update</li>
<li><a
href="https://github.com/smallstep/certificates/commit/8e76e290c0e37f09d13660ed2d5c8b01e80377d6"><code>8e76e29</code></a>
Disable govulncheck until go 1.25.5 is available in github actions (<a
href="https://redirect.github.com/smallstep/certificates/issues/2490">#2490</a>)</li>
<li><a
href="https://github.com/smallstep/certificates/commit/1011f5f5408b470a636f583bf74c0d7bbaf75d72"><code>1011f5f</code></a>
Improve validation in authorization path</li>
<li><a
href="https://github.com/smallstep/certificates/commit/48ed3a5d17d1224377d3a36d8e1a67575340c493"><code>48ed3a5</code></a>
Changelog updates for preparing for v0.29.0 (<a
href="https://redirect.github.com/smallstep/certificates/issues/2488">#2488</a>)</li>
<li><a
href="https://github.com/smallstep/certificates/commit/008e6ae94aa641c1350d84d0860c428f05dd444c"><code>008e6ae</code></a>
Merge pull request <a
href="https://redirect.github.com/smallstep/certificates/issues/2487">#2487</a>
from smallstep/dependabot/github_actions/softprops/a...</li>
<li><a
href="https://github.com/smallstep/certificates/commit/895e8c61bfbeda9baed298ba2350a9b1b59cd122"><code>895e8c6</code></a>
Bump softprops/action-gh-release from 2.4.2 to 2.5.0</li>
<li><a
href="https://github.com/smallstep/certificates/commit/930e8fc146c90736ffce71b4f8e62ae573fbd2c3"><code>930e8fc</code></a>
Merge pull request <a
href="https://redirect.github.com/smallstep/certificates/issues/2477">#2477</a>
from smallstep/dependabot/go_modules/golang.org/x/cr...</li>
<li><a
href="https://github.com/smallstep/certificates/commit/d7537894c5b534e585e1b794ca3272df0e857878"><code>d753789</code></a>
Bump golang.org/x/crypto from 0.44.0 to 0.45.0</li>
<li><a
href="https://github.com/smallstep/certificates/commit/07fa3454c6c88e9052d2d75e58350bd86d51b239"><code>07fa345</code></a>
Merge pull request <a
href="https://redirect.github.com/smallstep/certificates/issues/2481">#2481</a>
from smallstep/dependabot/go_modules/github.com/newr...</li>
<li>Additional commits viewable in <a
href="https://github.com/smallstep/certificates/compare/v0.28.4...v0.29.0">compare
view</a></li>
</ul>
</details>
<br />


[![Dependabot compatibility
score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/smallstep/certificates&package-manager=go_modules&previous-version=0.28.4&new-version=0.29.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores)

Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore <dependency name> major version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's major version (unless you unignore this specific
dependency's major version or upgrade to it yourself)
- `@dependabot ignore <dependency name> minor version` will close this
group update PR and stop Dependabot creating any more for the specific
dependency's minor version (unless you unignore this specific
dependency's minor version or upgrade to it yourself)
- `@dependabot ignore <dependency name>` will close this group update PR
and stop Dependabot creating any more for the specific dependency
(unless you unignore this specific dependency or upgrade to it yourself)
- `@dependabot unignore <dependency name>` will remove all of the ignore
conditions of the specified dependency
- `@dependabot unignore <dependency name> <ignore condition>` will
remove the ignore condition of the specified dependency and ignore
conditions
You can disable automated security fix PRs for this repo from the
[Security Alerts
page](https://github.com/liujed/caddy-dns01proxy/network/alerts).

</details>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs triage Waiting for discussion / prioritization by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants