Fix bug causing uploads to be identified as downloads #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, buttons for uploads and downloads weren't treated differently, and they should have been. Clicking the button of an upload would cause the code to attempt to download that file from the requesting user.
This PR prevents the buttons associated with uploads from doing anything when clicked (as there is nothing that can be done, other than cancel, and there's already a mechanism for that), and tweaks the UI to make them appear more like status indicators rather than buttons (removes cursor, removes mouseover effects)
Closes #260
Closes #306